Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [BOA/Cybersource] Pass commerce indicator using card network for apple pay #3782

Closed
wants to merge 9 commits into from

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Feb 22, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Apple pay transactions via BOA and Cybersource require a specific field commerce_indicator which is based on the card network type used during apple pay transactions.
https://docs.cybersource.com/content/dam/documentation/en/apple-pay/fdiglobal/so/applepay-so-fdiglobal.pdf

This data is now being passed using the card network data being shared from SDK during apple pay payments.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#3783

How did you test it?

Apple pay payments need to be tested using simplified and manual flow for connectors BOA and Cybersource

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration A-core Area: Core flows labels Feb 22, 2024
@deepanshu-iiitu deepanshu-iiitu self-assigned this Feb 22, 2024
@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners February 22, 2024 11:43
@deepanshu-iiitu deepanshu-iiitu added P-high Priority: High C-feature Category: Feature request or enhancement labels Feb 22, 2024
@deepanshu-iiitu deepanshu-iiitu added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 22, 2024
@deepanshu-iiitu deepanshu-iiitu changed the title feat(connector): [BOA/Cybersource] Pass commerce indicator using card network for apple pay" feat(connector): [BOA/Cybersource] Pass commerce indicator using card network for apple pay Feb 23, 2024
@deepanshu-iiitu
Copy link
Contributor Author

This changes are handled in #3795

@deepanshu-iiitu deepanshu-iiitu deleted the boa-cyb-apple-network branch February 23, 2024 08:06
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants